Skip to content

simplify Iterator::next for PercentEncode - #1012

Open
hkBst wants to merge 3 commits into
servo:mainfrom
hkBst:patch-2
Open

hkBst wants to merge 3 commits into
servo:mainfrom
hkBst:patch-2

Conversation

@hkBst

@hkBst hkBst commented Dec 23, 2024

Copy link
Copy Markdown
Contributor

This reduces duplication including of an unsafe block...

This reduces duplication including of an unsafe block...

Signed-off-by: Marijn Schouten <[email protected]>
@codecov

codecov Bot commented Dec 29, 2024 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@bcf5a2a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage        ?   86.92%           
=======================================
  Files           ?       26           
  Lines           ?     5256           
  Branches        ?        0           
=======================================
  Hits            ?     4569           
  Misses          ?      687           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hkBst
hkBst force-pushed the patch-2 branch 3 times, most recently from ccd1575 to 93551e2 Compare January 3, 2025 16:13
@hkBst

hkBst commented Jan 7, 2025

Copy link
Copy Markdown
Contributor Author

I'm a bit puzzled by the report of a leaked allocation. I'm pretty sure I did not introduce that, but I could be wrong.

Signed-off-by: Marijn Schouten <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant